-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP4: Handle more metadata #2179
Conversation
This is not something I expect, could you share a file with that so I can better understand from where it is?
I am not keen about having a Samsung specific field, it should be a generic field. It may be |
In a similar way, maybe |
Sample file from another Samsung phone here: #2175 (comment) This one shows
I got iOS sample from online which shows this:
|
Offtopic, while running a local build to ensure everything still builds fine, I found that ARM builds are failing with many errors regarding WindowsNamespace::... in file winbase.h |
It should be resolved with an update some time ago, and we build now ARM port with VS2022 on our build farm. |
I'll look into and see what is going on first. Since it built fine when MediaInfo 24.12 was released, it may be broken by a Visual Studio update. Edit: Found the cause. Setting C++20 std causes build failure for ARM64. @JeromeMartinez, the other PR needs changes. |
Even Samsung is not able to have a common scheme for where the model name is and where the marketing name is :). The "S23" stuff is in the "auth" metadata, expected to be the author/performer, not the model name, I guess I have to put check on some exception...s |
For the moment I merge and I'll update it soon with a different approach for the Android version. |
udta->smta->mdln
atomcom.android.version
metadataIssue #2175
MediaTrace:
MediaInfo: